major bug fix in setter patch

This commit is contained in:
Dima Granetchi
2014-11-13 22:24:55 +02:00
parent be2a4c6010
commit 99dc19c2d3
4 changed files with 48 additions and 8 deletions
+1 -1
View File
@@ -101,7 +101,7 @@ class BindMacros {
func.expr = macro { func.expr = macro {
var $OLD_VALUE = this.$fieldName; var $OLD_VALUE = this.$fieldName;
if ($i{OLD_VALUE} == $i{func.args[0].name}) return $i{OLD_VALUE}; if ($i{OLD_VALUE} == $i{func.args[0].name}) return $i{OLD_VALUE};
$e{func.expr.map(patchSetter)}; $e{patchSetter(func.expr)};
}; };
patchField = null; patchField = null;
case _: case _:
+43 -3
View File
@@ -1,19 +1,59 @@
package ; package ;
import bindx.Bind;
import bindx.IBindable;
import buddy.BuddySuite; import buddy.BuddySuite;
using buddy.Should;
class MetaTest extends BuddySuite { class MetaTest extends BuddySuite {
public function new() { public function new() {
describe("bindx should inherit @bindable meta", { describe("bindx should inherit @bindable meta", {
var b:BindableMeta;
var callNum:Int;
before({ before({
b = new BindableMeta();
callNum = 0;
}); });
it("bindx inherit metadata bindable for public fields"); it("bindx inherit metadata bindable for public fields", {
it("bindx inherit metadata params"); b.str = "a";
Bind.bind(b.str, function(_, _) callNum++);
b.str = "b";
callNum.should.be(1);
});
it("bindx inherit metadata bindable for public fields", {
b.str2 = "a";
Bind.bind(b.str2, function(_, _) callNum++);
b.str2 = "b";
callNum.should.be(1);
});
it("bindx inherit metadata params", {
Reflect.hasField(b, "strChanged").should.be(true); // lazySignal=false
Reflect.hasField(b, "str2Changed").should.be(true); // lazySignal=false
});
}); });
} }
} }
@:bindable(lazySignal=false)
class BindableMeta implements IBindable {
public var str:String;
public var str2(get, set):String;
function get_str2() return "";
function set_str2(value) return value;
public function new() {}
}